Symex: Simplify left-hand side #7700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
peterschrammel and
romainbrenguier
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7700 +/- ##
===========================================
- Coverage 78.50% 78.48% -0.02%
===========================================
Files 1674 1674
Lines 191954 191956 +2
===========================================
- Hits 150698 150666 -32
- Misses 41256 41290 +34
☔ View full report in Codecov by Sentry. |
peterschrammel
approved these changes
May 5, 2023
|
Is there a test that exhibits the problem? |
I will try to craft one (the aws-c-common example is too big a code base for a regression test). |
tautschnig
force-pushed
the
bugfixes/array-size-followup
branch
from
23853fe to
f0ac086
Compare
With diffblue#7622 we may have syntactically changed the type on the right-hand side via simplification. To maintain syntactic type equality we need to apply simplifications on the left-hand side as well. See https://github.com/awslabs/aws-c-common/actions/runs/4822448417 for an example where this failed after diffblue#7622.
tautschnig
force-pushed
the
bugfixes/array-size-followup
branch
from
f0ac086 to
dec8c60
Compare
tautschnig
added a commit
to awslabs/aws-c-common
that referenced
this pull request
May 15, 2023
This reverts commit 9848a8c ("Pin CBMC version to 5.81.0", PR #1022): CBMC 5.83.0 includes diffblue/cbmc#7700, which fixes the problem spotted by aws-c-common's tests.
graebm
pushed a commit
to awslabs/aws-c-common
that referenced
this pull request
May 15, 2023
This reverts commit 9848a8c ("Pin CBMC version to 5.81.0", PR #1022): CBMC 5.83.0 includes diffblue/cbmc#7700, which fixes the problem spotted by aws-c-common's tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #7622 we may have syntactically changed the type on the right-hand side via simplification. To maintain syntactic type equality we need to apply simplifications on the left-hand side as well. See https://github.com/awslabs/aws-c-common/actions/runs/4822448417 for an example where this failed after #7622.